Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(technicalUser): adjust technical user to delete dim users #804

Merged
merged 6 commits into from
Aug 5, 2024
Merged

feat(technicalUser): adjust technical user to delete dim users #804

merged 6 commits into from
Aug 5, 2024

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Jun 24, 2024 •
edited
Loading

Description

adjust technical user delete to support deletion of dim users

Why

To support the deletion of dim technical users

Issue

#809

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@Phil91 Phil91 force-pushed the feature/delete-technicalUser branch 2 times, most recently from 97bb107 to af206ea Compare June 24, 2024 12:25
@Phil91 Phil91 marked this pull request as ready for review June 24, 2024 12:45
@Phil91 Phil91 requested review from ntruchsess and evegufy June 24, 2024 12:45
@Phil91 Phil91 force-pushed the feature/delete-technicalUser branch from af206ea to 2f3aecd Compare June 28, 2024 07:23
@Phil91 Phil91 requested a review from ntruchsess June 28, 2024 07:25
@Phil91 Phil91 force-pushed the feature/delete-technicalUser branch 3 times, most recently from 0048700 to 82e96eb Compare July 4, 2024 11:06
@evegufy evegufy changed the base branch from release/v2.1.0-RC1 to release/v2.1.0-RC2 July 12, 2024 16:07
@ntruchsess ntruchsess force-pushed the feature/delete-technicalUser branch 10 times, most recently from fc70f6a to 9ee53af Compare July 19, 2024 13:44
@ntruchsess ntruchsess force-pushed the feature/delete-technicalUser branch 2 times, most recently from ccef406 to d211709 Compare July 19, 2024 16:55
evegufy
evegufy previously requested changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change is not going into the 2.1.0 version anymore, please change base branch to main

@Phil91 Phil91 force-pushed the feature/delete-technicalUser branch from d211709 to ebecf6f Compare July 26, 2024 09:10
@Phil91 Phil91 changed the base branch from release/v2.1.0-RC2 to main July 26, 2024 09:10
@ntruchsess ntruchsess force-pushed the feature/delete-technicalUser branch from ebecf6f to d211709 Compare July 26, 2024 09:30
@Phil91 Phil91 force-pushed the feature/delete-technicalUser branch from d211709 to 974d3b8 Compare July 26, 2024 10:50
@ntruchsess ntruchsess force-pushed the feature/delete-technicalUser branch 3 times, most recently from bfea01e to 8a2e8b0 Compare August 2, 2024 07:53
@ntruchsess
Copy link
Contributor

change is not going into the 2.1.0 version anymore, please change base branch to main

done

@ntruchsess ntruchsess force-pushed the feature/delete-technicalUser branch 2 times, most recently from 3b364e1 to c55cba7 Compare August 2, 2024 09:43
@ntruchsess ntruchsess force-pushed the feature/delete-technicalUser branch 2 times, most recently from 8f44923 to ba28535 Compare August 2, 2024 10:14
ntruchsess
ntruchsess previously approved these changes Aug 2, 2024
View reviewed changes
@ntruchsess ntruchsess force-pushed the feature/delete-technicalUser branch from ba28535 to 8b71e53 Compare August 2, 2024 11:29
ntruchsess
ntruchsess previously approved these changes Aug 2, 2024
View reviewed changes
@ntruchsess ntruchsess dismissed evegufy’s stale review August 2, 2024 12:47

requested change (change target and rebase to main) done

@ntruchsess ntruchsess force-pushed the feature/delete-technicalUser branch from 8b71e53 to bbb9cee Compare August 2, 2024 12:50
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Aug 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.1% Duplication on New Code

See analysis details on SonarCloud

@ntruchsess ntruchsess merged commit 48827b0 into main Aug 5, 2024
11 checks passed
@ntruchsess ntruchsess deleted the feature/delete-technicalUser branch August 5, 2024 11:26
@ntruchsess ntruchsess linked an issue Aug 5, 2024 that may be closed by this pull request
sig#809: API Enhancement OSP Customer Management - GET /api/administration/registration/network/companies Endpoint #850
Closed
@ntruchsess ntruchsess removed a link to an issue Aug 5, 2024
sig#809: API Enhancement OSP Customer Management - GET /api/administration/registration/network/companies Endpoint #850
Closed
@ntruchsess ntruchsess linked an issue Aug 5, 2024 that may be closed by this pull request
sig#803: API Enhancement - Deletion of External Technical Users #809
Closed
@evegufy evegufy modified the milestones: Release 24.12, Release 2.2.0 Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntruchsess ntruchsess ntruchsess approved these changes

@evegufy evegufy Awaiting requested review from evegufy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 2.2.0
Development

Successfully merging this pull request may close these issues.

sig#803: API Enhancement - Deletion of External Technical Users
4 participants
@Phil91 @ntruchsess @evegufy @jjeroch