Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(1.8.1): merge into release candidate branch #722

Merged
merged 3 commits into from
May 13, 2024

Conversation

evegufy
Copy link
Contributor

@evegufy evegufy commented May 8, 2024

Description

merge latest changes

Why

eclipse-tractusx/portal#299

evegufy and others added 2 commits May 8, 2024 10:35
* fix: add clients with composite roles to app_instances base seeding
Registration, Portal and technical_roles_management were accidentally maintained in consortia test data seeding
#718

* tests: adjust unit tests for composite roles

Refs: #718

---------

Co-authored-by: Phil Schneider <info@philschneider.de>
Copy link

gitguardian bot commented May 8, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9797321 Assigned Generic High Entropy Secret 6b4163c tests/portalbackend/PortalBackend.DBAccess.Tests/Seeder/Data/onboarding_service_provider_details.test.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@evegufy evegufy requested a review from Phil91 May 8, 2024 13:07
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ntruchsess ntruchsess dismissed Phil91’s stale review May 10, 2024 13:48

requested change was implemented

@evegufy evegufy marked this pull request as draft May 10, 2024 20:22
@evegufy
Copy link
Contributor Author

evegufy commented May 10, 2024

convert to draft to prevent this PR from being merged, as the comment #722 (comment) shouldn't have been solved with an additional commit but by solving the conflict during the merge of the release branch correctly, I'll redo the merge next week

@evegufy evegufy marked this pull request as ready for review May 13, 2024 07:06
@evegufy evegufy requested a review from Phil91 May 13, 2024 07:06
@evegufy evegufy merged commit 7bd96fc into release/v2.0.0-RC7 May 13, 2024
10 checks passed
@evegufy evegufy deleted the merge/v1.8.1 branch May 13, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants