Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set correct useAuthTrail #291

Merged
merged 1 commit into from
Oct 9, 2023
Merged

fix: set correct useAuthTrail #291

merged 1 commit into from
Oct 9, 2023

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Oct 9, 2023

Description

Remove the auth trail from the provisioning settings and use the keycloak settings to set the correct useAuthTrail value.

Why

With the current setting we'd need an extra configuration value where it is not needed.

Issue

N/A

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Phil91 Phil91 requested a review from ntruchsess October 9, 2023 06:50
@Phil91 Phil91 marked this pull request as ready for review October 9, 2023 06:50
@ntruchsess ntruchsess merged commit 502bbae into eclipse-tractusx:dev Oct 9, 2023
@ntruchsess ntruchsess deleted the bugfix/keycloak branch October 9, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntruchsess ntruchsess ntruchsess approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Phil91 @ntruchsess