New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(idp): set urls for idp update #1153

Merged

Phil91 merged 1 commit into release/v2.3.0-RC3 from bugfix/1152-idp

Nov 19, 2024

Member

Phil91 commented Nov 15, 2024

Description

Set the correct urls in the config when updating the idp

Why

To have the urls set in keycloak as well as in the database

Issue

Refs: #1152

Checklist

I have followed the contributing guidelines
I have performed IP checks for added or updated 3rd party libraries
I have created and linked IP issues or requested their creation by a committer
I have performed a self-review of my own code
I have successfully tested my changes locally
I have added tests that prove my changes work
I have checked that new and existing tests pass locally with my changes
I have commented my code, particularly in hard-to-understand areas


          fix(idp): set urls for idp update

e34b3aa

Refs: #1152

Phil91 requested a review from evegufy

November 15, 2024 16:41

Phil91 added this to the Release 2.3.0 (24.12) milestone

sonarqubecloud bot commented Nov 15, 2024

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Phil91 requested a review from ntruchsess

November 18, 2024 08:03

evegufy approved these changes

View reviewed changes

Phil91 merged commit eae3b36 into release/v2.3.0-RC3

11 of 12 checks passed

Phil91 deleted the bugfix/1152-idp branch

November 19, 2024 07:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet