New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add registration for missing services #1147

Merged

Phil91 merged 1 commit into release/v2.3.0-RC2 from bugfix/1144-services

Nov 13, 2024

Member

Phil91 commented Nov 13, 2024

Description

add service registration to RegistrationService
add service registration to MaintenanceApp

Why

The Registration Service and Maintenance App don't startup due to missing services.

Issue

Refs: #1144

Checklist

I have followed the contributing guidelines
I have performed IP checks for added or updated 3rd party libraries
I have created and linked IP issues or requested their creation by a committer
I have performed a self-review of my own code
I have successfully tested my changes locally
I have added tests that prove my changes work
I have checked that new and existing tests pass locally with my changes
I have commented my code, particularly in hard-to-understand areas


          fix: add registration for missing services

432ea10

Refs: #1144

Phil91 requested review from ntruchsess and evegufy and removed request for ntruchsess

November 13, 2024 10:18

sonarqubecloud bot commented Nov 13, 2024

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

evegufy approved these changes

View reviewed changes

Phil91 merged commit 14e6d1a into release/v2.3.0-RC2

10 checks passed

Phil91 deleted the bugfix/1144-services branch

November 13, 2024 10:51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet