Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust query to get users for role assignment #1135

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Nov 8, 2024

Description

Adjusted the query to get users for the initial role assignment

Why

Currently the query filters users which don't have the initial roles assigned out of the result, thus no users gets the roles assigned.

Issue

Refs: #1134

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@Phil91 Phil91 requested a review from evegufy November 8, 2024 14:02
@Phil91 Phil91 changed the base branch from main to release/v2.3.0-RC2 November 8, 2024 14:13
@Phil91 Phil91 added this to the Release 2.3.0 (24.12) milestone Nov 8, 2024
@Phil91 Phil91 force-pushed the bugfix/1134-assign-roles branch from cd8abea to f035718 Compare November 8, 2024 14:21
Copy link

sonarqubecloud bot commented Nov 8, 2024

@Phil91 Phil91 merged commit 0cb26c0 into release/v2.3.0-RC2 Nov 8, 2024
10 checks passed
@Phil91 Phil91 deleted the bugfix/1134-assign-roles branch November 8, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

2 participants