Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connector): only provider should update connector #1086

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+46 −15
Open

fix(connector): only provider should update connector #1086

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
22f4b07
fix(connector): only provider should update connector
dhiren-singh-007 Oct 21, 2024
152b2ec
fix the new changes from main
dhiren-singh-007 Nov 14, 2024
be5e436
added unit test to check is provider
dhiren-singh-007 Nov 14, 2024
d7936d6
fix git codeql issue
dhiren-singh-007 Nov 14, 2024
e6e07df
fix null ref issue
dhiren-singh-007 Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions tests/portalbackend/PortalBackend.DBAccess.Tests/ConnectorRepositoryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@
// Assert
result.Should().BeNull();
}

Check warning

Code scanning / CodeQL

Dereferenced variable may be null Warning test

Variable
result
Loading
may be null at this access as suggested by
this
Loading
null check.
[Fact]
public async Task GetConnectorUpdateInformation_ReturnIsProviderTrue()
{
Expand All @@ -442,9 +442,12 @@

// Assert
result.Should().NotBeNull();
result?.IsProviderCompany.Should().BeTrue();
if (result != null)
{
result.IsProviderCompany.Should().BeTrue();
}
dhiren-singh-007 marked this conversation as resolved.
Show resolved Hide resolved
}

Fixed Show fixed Hide fixed
Fixed Show fixed Hide fixed
[Fact]
public async Task GetConnectorUpdateInformation_ReturnIsProviderFalse()
{
Expand All @@ -456,7 +459,10 @@

// Assert
result.Should().NotBeNull();
result?.IsProviderCompany.Should().BeFalse();
if (result != null)
{
result.IsProviderCompany.Should().BeFalse();
}
dhiren-singh-007 marked this conversation as resolved.
Show resolved Hide resolved
}

#endregion
Expand Down
Loading