fix(unittests): remove some redundancy from ServiceAccountBusinessLogic unit-tests #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntruchsess
changed the title
ntruchsess
changed the title
3 tasks
|
Phil91
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unit-tests for ServiceAccountBusinessLogic were adjusted.
Encoding of latest migrations was set to utf8
Why
in #997 unit-tests were changed removing existing dim/non-dim data differentiation and adding redundancy. That was adjusted to ensure unit-tests remain maintainable.
Encoding of latest migration was UTF8 with BOM. UTF8 without BOM should be used instead.
Issue
#976
Checklist
Please delete options that are not relevant.