Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(registration): fixed the company name change in IDP #1010

Conversation

dhiren-singh-007
Copy link
Contributor

Description

Added method to update display name and organisation attribute value in Identity provider in keycloak

Why

This was causing mismatch issue in login screen for company name and also in the user profile menu after login in portal

Issue

#942

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes

@ntruchsess ntruchsess self-assigned this Sep 19, 2024
Copy link
Contributor

@ntruchsess ntruchsess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments. Please also fix the sonar issues

@ntruchsess ntruchsess linked an issue Sep 19, 2024 that may be closed by this pull request
@dhiren-singh-007 dhiren-singh-007 force-pushed the bugfix/company-name-change branch from 6e09951 to e42e44e Compare October 15, 2024 09:46
@dhiren-singh-007 dhiren-singh-007 force-pushed the bugfix/company-name-change branch from e42e44e to 976d5c9 Compare October 22, 2024 13:11
@dhiren-singh-007
Copy link
Contributor Author

dhiren-singh-007 commented Oct 23, 2024

@ntruchsess : I would need your help here regarding the comment for moving the method after CreateCentralIdentityProviderOrganisationMapperAsync ,ref : #1010 (comment)
So i moved the method in this file IdpManagement.cs, now in order to use this file in Registration service i have to inject dependency using the method AddIdpManagement from src/externalsystems/Provisioning.Library/DependencyInjection/ProvisioningLibraryExtensions.cs but then it requires configuration to be added in Registration service which doesn't make sense as they are not needed in registration service.

@evegufy evegufy added this to the Release 2.3.0 (24.12) milestone Oct 24, 2024
@Phil91 Phil91 changed the base branch from main to release/v2.3.0-RC2 October 25, 2024 05:45
@dhiren-singh-007 dhiren-singh-007 requested review from ntruchsess and removed request for ntruchsess October 30, 2024 15:00
@ntruchsess ntruchsess force-pushed the bugfix/company-name-change branch from 8173ff8 to f8ff20a Compare November 4, 2024 15:48
@ntruchsess ntruchsess force-pushed the bugfix/company-name-change branch from f8ff20a to d0e9a1b Compare November 5, 2024 07:56
Copy link

sonarqubecloud bot commented Nov 5, 2024

@ntruchsess ntruchsess merged commit af32ca4 into eclipse-tractusx:release/v2.3.0-RC2 Nov 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

Registration | Company Name Change Not Reflecting Consistently
4 participants