-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tech user): add internal invitation tech user #1002
feat(tech user): add internal invitation tech user #1002
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@typecastcloud technically this looks fine, but you do not declare to have tested the change (together with iam-data in eclipse-tractusx/portal-iam#189) at least locally?
(I can see the unit-tests in CI are failing, but that seems to be unrelated to your change. I'll look into that)
Hi @ntruchsess, I converted the PRs back to draft until I have fully tested this. I only ran dotnet test until now and was trying to find the reason for the failing test in pipeline. I first requested initial review from internal developers to get help fully testing the changes. Thank you for the quick reply. |
@ntruchsess tests are all green now. I also used the wrong offer id in user_roles.json. I'll run everything locally once and check if correct client gets createn. After that I'll set to ready for review. |
@typecastcloud could you please resolve the conflicts? In my opinion everything else looks good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@typecastcloud : please resolve the conflict in CHANGELOG.md by doing a rebase on latest main.
Allows adding technical user for invitation api as CX Operator. Refs: eclipse-tractusx#932
Use "Technical User Management" instead of "Portal".
Technical User Management as offer id in Registration Internal requires updated tests.
9e00545
to
927bc1a
Compare
@Phil91 @ntruchsess rebased and changelog is adjusted. New line was missing at the end of the changelog too. |
This reverts commit 927bc1a.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@typecastcloud : unit-test GetServiceAccountRolesAsync_WithValidData_ReturnsExpected is failing. An additional assert has been added on main that needs to be adjusted in the PR (see my suggested change)
tests/portalbackend/PortalBackend.DBAccess.Tests/UserRolesRepositoryTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Norbert Truchsess <norbert.truchsess@t-online.de>
Quality Gate passedIssues Measures |
Description
Add
Registration Internal
as new technical user that can be created in portal.New
technical_roles_management
composite role with nameRegistration Internal
with:invite_new_partner
view_submitted_applications
is also being added as new client role in eclipse-tractusx/portal-iam#189
Why
Operator company wants to integrate 3rd party service to send out invites. Allows inviting and reviewing status via API.
Issue
Refs: #932
Related: eclipse-tractusx/portal-iam#189
Checklist
Please delete options that are not relevant.