Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedback fixes #496

Merged
merged 6 commits into from
Oct 6, 2023
Merged

Feedback fixes #496

merged 6 commits into from
Oct 6, 2023

Conversation

SergioCasCeb
Copy link
Contributor

For this pull request, some initial UI and functionality issues were solved:

  • Changed the text for the filter input within the examples menu.
  • Fixed the bug with the visualization view buttons. (Tree and Graph buttons can not be selected if the user is in that current view)
  • Resized the header slightly to allow for more space (which also caused a change in the overall size of all components).
  • The text color in the share TD/TM input field now adapts to the respective theme colors.
  • The interaction buttons for the examples have been changed to better convey their usage, as well as removing the non-working "show snippet" button."

@SergioCasCeb
filter placeholder
be80cd4 
Changed the filter placeholder to "Find examples based on card details" to help avoid confusion with the actual TD json files
@SergioCasCeb
Fixed visualize buttons
1694fa9 
When picking a visualization type the button gets disable so that it cannot be clicked again and reset all the changes made
@SergioCasCeb
resized header and fonts
06cd7eb 
The fonts and size of the header were changed to be slightly smaller and give the main application a little bit more space
@SergioCasCeb
excluding the web-new package from lerna
fbafe1b
@SergioCasCeb
text color in share input
83f20d9 
Fixed the text color in the share td input so that it changes color when the page theme also changes
@SergioCasCeb
New example interaction buttons
d585042 
The interaction buttons were modified to better convey their respective usage and help the user understand the process and options better
@egekorkan
Copy link
Member

So this takes into account the feedback of @danielpeintner , @FadySalama and @relu91 from the discussion #492 . There are some other ones leftover such as:

  • Quicker example access
  • Logo redesign
  • Example filter menu redesign

@egekorkan egekorkan merged commit 1db5081 into eclipse-thingweb:master Oct 6, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egekorkan egekorkan egekorkan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SergioCasCeb @egekorkan