Tests for mqtt interactions #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hasan Eroglu <hasanheroglu@gmail.com>
Signed-off-by: Hasan eroglu <hasanheroglu@gmail.com>
Signed-off-by: Hasan eroglu <hasanheroglu@gmail.com>
Signed-off-by: Hasan eroglu <hasanheroglu@gmail.com>
Signed-off-by: Hasan eroglu <hasanheroglu@gmail.com>
Signed-off-by: Hasan eroglu <hasanheroglu@gmail.com>
|
Tests were failing for |
Signed-off-by: Hasan eroglu <hasanheroglu@gmail.com>
relu91
requested changes
May 12, 2023
There was a problem hiding this comment.
Some inputs:
- The testing file is called mqtt-client-subscribe-test.integration.ts : the new tests are about writing and invoking actions. We have two options: rename the file to mqtt-client-test.integration.ts and use a describe to group the different tests OR move the new tests in a new file.
- You tested for different input types which is great, but there is a lot of duplicated code. Can you try to refactor it to have less code duplicated?
- I left some minor comments below about timeouts and failing.
packages/binding-mqtt/test/mqtt-client-subscribe-test.integration.ts
Outdated
Show resolved
Hide resolved
packages/binding-mqtt/test/mqtt-client-subscribe-test.integration.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Hasan eroglu <hasanheroglu@gmail.com>
|
Note: I noticed you merged in master which was not a good idea since the testing is broken at the moment but we are about to fix that, see #995 |
|
FYI: #995 has been merged and merging in master again should run the test workflow again. |
JKRhb
reviewed
May 26, 2023
JKRhb
reviewed
May 26, 2023
JKRhb
reviewed
May 26, 2023
Co-authored-by: Jan Romann <jan.romann@uni-bremen.de>
Co-authored-by: Jan Romann <jan.romann@uni-bremen.de>
Signed-off-by: Hasan Eroglu <hasanheroglu@gmail.com>
…/thingweb.node-wot into tests-for-mqtt-interactions
…/thingweb.node-wot into tests-for-mqtt-interactions
Signed-off-by: Hasan Eroglu <hasanheroglu@gmail.com>
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #992 +/- ##
==========================================
+ Coverage 74.64% 75.79% +1.15%
==========================================
Files 72 72
Lines 14882 14856 -26
Branches 1412 1429 +17
==========================================
+ Hits 11108 11260 +152
+ Misses 3741 3563 -178
Partials 33 33
|
relu91
approved these changes
May 29, 2023
danielpeintner
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.