refactor(binding-coap): refactor server's destroy method #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JKRhb
force-pushed
the
refactor-coap-server
branch
from
7b6b060 to
39a1ba4
Compare
danielpeintner
approved these changes
May 10, 2023
JKRhb
commented
May 10, 2023
relu91
approved these changes
May 10, 2023
JKRhb
force-pushed
the
refactor-coap-server
branch
from
88e865e to
3046655
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the context of #963. I noticed that the
CoapServer'sdestroymethod could use some cleanup. This PR refactors the method a bit, usingasync/awaitinstead of aPromise, making the code a bit more readable.There are other places like these elsewhere in the code, I will try to do some further cleanup when I'll continue working on #963 and issues like #982.