fix(binding-mqtt): fix sending plain value instead of content object #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes eclipse-thingweb#979 Signed-off-by: Hasan Eroglu <hasanheroglu@gmail.com>
|
Since segment indices are wrong, I could not add tests. If it is okay, I will add the tests with segment indices fix. |
Signed-off-by: Hasan Eroglu <hasanheroglu@gmail.com>
I think the fix is easy enough that tests can (and should) follow later. |
Signed-off-by: Hasan Eroglu <hasanheroglu@gmail.com>
Signed-off-by: Hasan Eroglu <hasanheroglu@gmail.com>
|
We will definitely follow up with the tests since so many PRs are interlinked at the moment. |
danielpeintner
approved these changes
May 11, 2023
relu91
requested changes
May 11, 2023
Signed-off-by: Hasan eroglu <hasanheroglu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #979