fix: report allproperties with proper type #985
Conversation
|
Note: readallproperties does not report any value other than JSON. In the test added SVG is not reported. I think this is the best we can do... |
|
I agree that this is a spec issue (even more so than an implementation issue) |
|
See w3c/wot-thing-description#1814 for more discussions |
There was a problem hiding this comment.
I definitely agree this is the best we can do and if properly specified in the spec is not even a problem I think.
What is a little bit weird with the current architecture is that the HTTP server needs to know how to serialize the payload. I would not block this PR for this, but I think in the future we should have a second look.
| @@ -549,6 +549,100 @@ class HttpServerTest { | |||
| return httpServer.stop(); | |||
| } | |||
|
|
|||
| @test async "should report allproperties"() { | |||
There was a problem hiding this comment.
| @test async "should report allproperties"() { | |
| @test async "should report allproperties excluding no json properties"() { |
or create two tests with one with only json properties and one like the current version.
There was a problem hiding this comment.
I had to re-read it multiple times to get it right.. but I think the addition should read
"excluding non-JSON properties"
@relu91 what do you think?
see additional proposed change below
Co-authored-by: danielpeintner <daniel.peintner@gmail.com>
fixes #984