Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Node.js 20 and remove Node.js 14 workflow #974

Merged
merged 2 commits into from
May 12, 2023

Conversation

danielpeintner
Copy link
Member

Note: we can also start "thinking" about removing Node.js 14

@egekorkan
Copy link
Member

Note: we can also start "thinking" about removing Node.js 14

Yup we can remove it. We used to keep older versions due to Eclipse server but that is nicely updated to 16 and we can update further if needed.

@danielpeintner
Copy link
Member Author

Note: I removed Node.js 14 from GitHub action workflow.
Question: shall we exclude mbus from package.json like we do for firestore till we have a solution?
https://github.com/eclipse/thingweb.node-wot/blob/master/package.json#L41

@danielpeintner danielpeintner changed the title chore: add Node.js 20 workflow chore: add Node.js 20 and remove Node.js 14 workflow May 10, 2023
Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are all green I would merge it.

@danielpeintner
Copy link
Member Author

Interesting. The test used to fail because of issues with mbus but they seem to be gone after i restarted the workflow.

@egekorkan you noticed the same issues with mbus and Node.JS 20.
Can you check whether they are gone on our side as well

@egekorkan
Copy link
Member

Interesting. The test used to fail because of issues with mbus but they seem to be gone after i restarted the workflow.

@egekorkan you noticed the same issues with mbus and Node.JS 20. Can you check whether they are gone on our side as well

Yes it is gone as well

@danielpeintner danielpeintner merged commit 137f2e5 into eclipse-thingweb:master May 12, 2023
@danielpeintner
Copy link
Member Author

The workflow now refuses to run
see https://github.com/eclipse/thingweb.node-wot/actions/runs/4960136649

Let's see whether this issue is just the case for this specific case

@JKRhb
Copy link
Member

JKRhb commented May 12, 2023

The workflow now refuses to run see https://github.com/eclipse/thingweb.node-wot/actions/runs/4960136649

Let's see whether this issue is just the case for this specific case

Hmm, I think there is an opening square bracket missing in the workflow file.

@relu91
Copy link
Member

relu91 commented May 12, 2023

Some how we got a greenlight from Github but he didn't actually run CI. Something we have to look after next time :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants