-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add Node.js 20 and remove Node.js 14 workflow #974
chore: add Node.js 20 and remove Node.js 14 workflow #974
Conversation
Yup we can remove it. We used to keep older versions due to Eclipse server but that is nicely updated to 16 and we can update further if needed. |
Note: I removed Node.js 14 from GitHub action workflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are all green I would merge it.
Interesting. The test used to fail because of issues with mbus but they seem to be gone after i restarted the workflow. @egekorkan you noticed the same issues with mbus and Node.JS 20. |
Yes it is gone as well |
The workflow now refuses to run Let's see whether this issue is just the case for this specific case |
Hmm, I think there is an opening square bracket missing in the workflow file. |
Some how we got a greenlight from Github but he didn't actually run CI. Something we have to look after next time :/ |
Note: we can also start "thinking" about removing Node.js 14