-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: re-run failed test steps with debug logging enabled #1189
Conversation
364d74a
to
c26c563
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1189 +/- ##
==========================================
- Coverage 76.66% 76.64% -0.02%
==========================================
Files 80 80
Lines 16813 16821 +8
Branches 1618 1619 +1
==========================================
+ Hits 12890 12893 +3
- Misses 3893 3898 +5
Partials 30 30 ☔ View full report in Codecov by Sentry. |
Enabling debug logging on a second try does seem to work :) See this run for example: https://github.com/eclipse-thingweb/node-wot/actions/runs/7165425102/job/19507350139?pr=1189 |
e0cf7c6
to
c26c563
Compare
Should we go for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That may become very handy!
Hmm, I would assume that if the retry should succeed using the |
Yes, I think we should always fail if we re-try... but maybe not because the coverage step should fail... we should signal it better. Is it possible to configure the action to fail if it re-tries? |
220fcab
to
8e73dd9
Compare
This should now be incorporated :) "Unfortunately", the MQTT tests have not been failing anymore so the behavior in this specific case could not really be tested by me so far. However, after triggering a "manual" the updated action step (more or less) showed the correct behavior. Update: I now managed to successfully test the expected behavior in this workflow run (with a slightly adjusted workflow file): https://github.com/eclipse-thingweb/node-wot/actions/runs/7173674190/job/19533532357?pr=1189 |
2f6514e
to
6595d90
Compare
Hmm, as the failed CI run shows, the current approach does not work for Windows yet and needs to be slightly adjusted... |
This PR introduces a retry mechanism with enabled debug logging for failed CI testing steps as discussed in #1184 (comment).