Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(td-tools/AID): add AID JSON schema #1157

Merged

Conversation

danielpeintner
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (cc46531) 76.64% compared to head (17d7873) 76.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1157      +/-   ##
==========================================
+ Coverage   76.64%   76.65%   +0.01%     
==========================================
  Files          80       80              
  Lines       16636    16661      +25     
  Branches     1601     1604       +3     
==========================================
+ Hits        12750    12772      +22     
  Misses       3859     3859              
- Partials       27       30       +3     
Files Coverage Δ
...s/td-tools/src/util/asset-interface-description.ts 72.94% <82.52%> (+0.26%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielpeintner
Copy link
Member Author

Note: I improved the code to do best effort approach if base is missing in TDs (which is required for AID) by looking at property forms.

@sebastiankb
Copy link
Contributor

thanks for the update. looks good for merge

@danielpeintner danielpeintner merged commit 5eb0ca4 into eclipse-thingweb:master Nov 10, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants