Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): re-enable Node 20 #1056

Merged
merged 4 commits into from
Aug 11, 2023
Merged

Conversation

JKRhb
Copy link
Member

@JKRhb JKRhb commented Aug 11, 2023

This PR updates the node-mbus dependency, incorporating a fix for Node 20, and re-enables the corresponding CI workflow.

Fixes #1004.

@JKRhb
Copy link
Member Author

JKRhb commented Aug 11, 2023

Hmm. For some reason, the CI still fails on Node 20 (but for a different reason now?) I will investigate this a bit more.

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #1056 (d0db9b7) into master (597f34d) will decrease coverage by 0.06%.
Report is 15 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1056      +/-   ##
==========================================
- Coverage   75.54%   75.49%   -0.06%     
==========================================
  Files          80       80              
  Lines       15341    15386      +45     
  Branches     1460     1469       +9     
==========================================
+ Hits        11590    11616      +26     
- Misses       3717     3735      +18     
- Partials       34       35       +1     

see 4 files with indirect coverage changes

@JKRhb
Copy link
Member Author

JKRhb commented Aug 11, 2023

I have been able to identify the installation step of npm 7 as the last remaining cause of this issue :) A full fix should therefore be around the corner.

@JKRhb JKRhb marked this pull request as ready for review August 11, 2023 10:49
@JKRhb
Copy link
Member Author

JKRhb commented Aug 11, 2023

The PR should now be ready for review :)

Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! thank you @JKRhb 🎉. I'm also glad that we finally can get off that custom step for installing npm 7. Good to go.

Copy link
Member

@danielpeintner danielpeintner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good, thank you 👍

Can you remove also the following line in this PR

> Node.js version 20 is not yet supported (https://github.com/eclipse-thingweb/node-wot/issues/1004)

@relu91 relu91 requested a review from danielpeintner August 11, 2023 12:53
@danielpeintner danielpeintner merged commit e0e3fc4 into eclipse-thingweb:master Aug 11, 2023
@JKRhb JKRhb deleted the node-20 branch August 11, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node.js 20 workflow causes issues with modbus and mbus binding (related to serialport)
3 participants