-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): re-enable Node 20 #1056
Conversation
Hmm. For some reason, the CI still fails on Node 20 (but for a different reason now?) I will investigate this a bit more. |
Codecov Report
@@ Coverage Diff @@
## master #1056 +/- ##
==========================================
- Coverage 75.54% 75.49% -0.06%
==========================================
Files 80 80
Lines 15341 15386 +45
Branches 1460 1469 +9
==========================================
+ Hits 11590 11616 +26
- Misses 3717 3735 +18
- Partials 34 35 +1 |
I have been able to identify the installation step of npm 7 as the last remaining cause of this issue :) A full fix should therefore be around the corner. |
The PR should now be ready for review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! thank you @JKRhb 🎉. I'm also glad that we finally can get off that custom step for installing npm 7. Good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good, thank you 👍
Can you remove also the following line in this PR
Line 103 in 597f34d
> Node.js version 20 is not yet supported (https://github.com/eclipse-thingweb/node-wot/issues/1004) |
This PR updates the node-mbus dependency, incorporating a fix for Node 20, and re-enables the corresponding CI workflow.
Fixes #1004.