Use @node-oauth/express-oauth-server instead of express-oauth-server #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielpeintner
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we know the
express-oauth-servergave us some headaches because it was using a vulnerable version of loadsh (or some other library). Sadly, the development of such a tool was discontinued and we were left with a broken dependency that gave us bad audit scores. Thanks to the work in node-oauth, we now have a new version of the server with 0 vulnerabilities. This PR upgrade our dependency list with the new service. We are now down to 8 vulnerabilities but 0 critical (I also tried to solve netconf vulnerability but it seems that the library it is not very active for a long time).See also node-oauth/express-oauth-server#5