Merge pull request #198 from eclipse-thingweb/trusted-roots

Reactivate `withTrustedRoots` by default in HTTP binding
eclipse-thingweb · Nov 4, 2024 · 3f40b8a · 3f40b8a
2 parents a3156ac + e7dc1fe
commit 3f40b8a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/src/binding_http/http_client.dart b/lib/src/binding_http/http_client.dart
@@ -54,7 +54,9 @@ final class HttpClient extends ProtocolClient
             IOClient(io.HttpClient(context: _createContext(httpClientConfig)));
 
   static SecurityContext _createContext(HttpClientConfig? httpClientConfig) {
-    final context = SecurityContext();
+    final context = SecurityContext(
+      withTrustedRoots: httpClientConfig?.withTrustedRoots ?? true,
+    );
 
     final trustedCertificates = httpClientConfig?.trustedCertificates ?? [];
 

diff --git a/lib/src/binding_http/http_config.dart b/lib/src/binding_http/http_config.dart
@@ -25,9 +25,14 @@ class HttpConfig {
 class HttpClientConfig {
   /// Creates a new [HttpClientConfig] object.
   const HttpClientConfig({
+    this.withTrustedRoots = true,
     this.trustedCertificates,
   });
 
+  /// Indicates whether the security contexts created from this config will
+  /// incorporate trusted root certificates from the underlying platform.
+  final bool withTrustedRoots;
+
   /// List of trusted certificates that will be added to the security contexts
   /// of newly created HTTP clients.
   ///