vsx: fix search input behavior #9772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
added
the
vsx-registry
The commit fixes the search input behavior which would always move the cursor to the end of the input when inputting characters, even those in between. The issue was the mismatch of react controlled and uncontrolled input, which would mean keeping a state about the cursor during updates. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
force-pushed
the
vf/vsx-react
branch
from
b907bc0 to
e2303c7
Compare
msujew
approved these changes
Jul 23, 2021
colin-grant-work
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #9771
The commit fixes the search input behavior which would always move the cursor to the end of the input when inputting characters, even those in between. The issue was the mismatch of react controlled and uncontrolled input, which would mean keeping a state about the cursor during updates.
How to test
extensions-viewclear-alltoolbar item - should clear the search input@builtin- the results should show installed builtinsReview checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com