siw: improve search result message #9429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
added
enhancement
alvsan09
approved these changes
May 4, 2021
paul-marechal
approved these changes
Jul 6, 2021
The following commit improves the search result message upon completing a search-in-workspace search. The message is improved to handle additional options: - no results without options. - no results when including `includes`. - no results when including `excludes`. - no results when including `includes` and `excludes`. - displaying stats when results are found. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
force-pushed
the
vf/siw-message
branch
from
2fb7067 to
d626574
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The following pull-request updates the
search-in-workspaceresult message (which is displayed upon searching) by adding support for additional use-cases and options.The changes should now support the following messages:
includesandexcludesare present.includesis present.excludesis present.How to test
For each of the tests, start the application and open the
search-in-workspaceview:No results found- search for a non-existing term withoutincludesorexcludesset.No results found in {a} excluding {b}- search for a non-existing term withincludesandexcludespresent.No results found in {a}- search for a non-existing term withincludespresent.No results found excluding {a}- search for a non-existing term withexcludespresent.The message when results are found should be the same as in
master.Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com