custom-editor: remove 'editor-preview` coupling #9302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following commit removes the unnecessary coupling to `@theia/editor-preview` from `custom-editor` functionality contributed by the plugin-system. Adding the coupling was a breaking change for downstream applications who were not expecting `@theia/editor-preview` from being contributed, and meant it was difficult to opt-out. The coupling was introduced to add unused typing so it is safe to remove. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
added
quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #9300
The following pull-request updates the breaking changes introduced by #8910 (support for
custom-editors) which included new coupling to@theia/editor-preview. The coupling meant that downstream applications would unnecessarily pull@theia/editor-previewwithout expecting it, and would not be able to easily opt-out (or would require new customizations).The changes include removing the dependency, and removing the unused typing as part of the
canHandlesince it was unused.How to test
custom-editorsstill work correctly (using the vscode-cat-customs plugin).Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com