fix #7680 remove css escape for html class attribute

[kesslerdev]

What it does

• Fix issue [theming] file-icon incorrectly displays name icon with a dot in name #7680
• replace escaped dots in class names used for html class attribute only.

How to test

1. Start Theia on gitpod & install Material Icon Theme from open vsx registry

Without fix:

With fix:

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[akosyakov]

sorry that it takes so long, any reason for draft? Could you sign ECA please that we can proceed: https://github.com/eclipse-theia/theia/blob/master/CONTRIBUTING.md#eclipse-contributor-agreement

[kesslerdev]

sorry that it takes so long, any reason for draft? Could you sign ECA please that we can proceed: https://github.com/eclipse-theia/theia/blob/master/CONTRIBUTING.md#eclipse-contributor-agreement

Yes it's done

[akosyakov]

There is https://github.com/kesslerdev/theia/blob/471df16110403576e83d73628a9a0148aec7e0df/packages/plugin-ext/src/main/browser/plugin-icon-theme-service.ts#L339 method. Should not we rather improve it? It seems to be caused by CSS.escape, so maybe we just drop it and always replace all other characters with -. It would avoid any other regex lookups.

[akosyakov]

looks way better now, thank you!

[vince-fugnitto]

The change looks good to me, the file-icons for example are successfully displayed: