-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/preferences ui tab styling #7793
Feature/preferences ui tab styling #7793
Conversation
1cfa453
to
e5f8d3e
Compare
Known issues: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kenneth-marut-work do you mind rebasing and squashing your commits before we proceed with the review?
Signed-off-by: Kenneth Marut <kenneth.marut@ericsson.com>
e5f8d3e
to
509d8ce
Compare
@vince-fugnitto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified the changes they look very nice 👍
I see that:
- active tab is properly highlighted
- active tab is now highlighted at the bottom (hover works nicely as well)
- the shadow-border is correctly visible only when scrolling
- verified using multiple themes (light + dark)
Merging! Thank you for your contribution @kenneth-marut-work 👍 |
@vince-fugnitto you're welcome, thanks for the review + merge! |
What it does
Fixes #7768
This PR addresses issue #7768 to only show the preferences tabbar shadow when the editor is scrolled, and also provides some additional styling improvements to the preferences tab bar to be more in-line with VSCode including:
How to test
Review checklist
Reminder for reviewers