Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix file icons in explorer are not aligned if file name is truncated #7730

Merged
merged 1 commit into from
May 5, 2020
Merged

fix file icons in explorer are not aligned if file name is truncated #7730

merged 1 commit into from
May 5, 2020

Conversation

DoroNahari
Copy link
Contributor

What it does

Fixes #7720

before: see gif in #7720
after:
Screen-Recording-2020-05-04-at-0 45 37
all stay in place

Review checklist

Reminder for reviewers

@akosyakov akosyakov requested a review from vince-fugnitto May 4, 2020 07:19
@akosyakov
Copy link
Member

We should that it does not have side effects on other places where file icons are used, editor titles, scm view and so on.

@akosyakov akosyakov requested a review from lmcbout May 4, 2020 07:20
@akosyakov akosyakov added the theming issues related to theming label May 4, 2020
lmcbout
lmcbout approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@lmcbout lmcbout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icon stay the same in explorer when using electron or the Chrome browser
Tested on Ubuntu 18.04
Note. I noticed in the explorer view, when using a long name for the workspace, it flikkers between the name and the icon when resizing. This is minor.

vince-fugnitto
vince-fugnitto approved these changes May 4, 2020
View reviewed changes
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, I tested the following:

  • explorer when truncated
  • problems-view
  • outline-view
  • search-in-workspace
  • quick-file open
  • editor tabs

I could not find any regressions.

@DoroNahari DoroNahari closed this May 4, 2020
@DoroNahari
fix file icons in explorer are not aligned if file name is truncated
3f206cf 
Signed-off-by: Doron Nahari <doron.nahari@sap.com>
@DoroNahari DoroNahari reopened this May 4, 2020
@DoroNahari
Copy link
Contributor Author

I accidentally closed the pr. please merge if everything looks good

@lmcbout lmcbout merged commit 57f4c93 into eclipse-theia:master May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmcbout lmcbout lmcbout approved these changes

@vince-fugnitto vince-fugnitto vince-fugnitto approved these changes

Assignees
No one assigned
Labels
theming issues related to theming
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File icons in explorer are not aligned if file name is truncated
4 participants
@DoroNahari @akosyakov @lmcbout @vince-fugnitto