[task] fix miscellaneous typos present in the task extension #6780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Description** - fixes miscellaneous typos present in the `@theia/task` extension. **Breaking Changes** - the method `reorgnizeTasks()` has been renamed to `reorganizeTasks()`. - the method `getStrigifiedTaskSchema()` has been renamed to `getStringifiedTaskSchema()`. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
force-pushed
the
vf/task-typos
branch
from
ef8529d
to
1d9aa60
Compare
RomanNikitenko
approved these changes
Dec 20, 2019
There was a problem hiding this comment.
LGTM
@vince-fugnitto
thank you very much for letting me know about breaking changes: I checked it for our project - it's OK.
@vince-fugnitto @elaihau
btw: I'm going to have vacation till 02.01.20, please don't wait for my review in PRs
thank you!
8 tasks
elaihau
approved these changes
Dec 22, 2019
|
Thank you @RomanNikitenko @elaihau |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Description
@theia/taskextension.Breaking Changes
reorgnizeTasks()has been renamed toreorganizeTasks().getStrigifiedTaskSchema()has been renamed togetStringifiedTaskSchema().How to test
@theia/taskextension).Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com