Allow to use HTTP resources for webview tabs

[vitaliy-guliy]

Signed-off-by: Vitaliy Gulyy vgulyy@redhat.com

What it does

Makes it possible to use HTTP icons for webview tabs opened by plugins.
Adds unimplemented functionality. WebView plugin API describes that any URI referencing on an image can be used for tab icon.

How to test

It's a part of the plugin system.
To test you have to

• open a webview from your plugin
• update tab icon with an URI referencing on a remote HTTP image resource

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[akosyakov]

@vitaliy-guliy sample VS Code extension would help to verify

@olexii4 Could you have a look please?

[akosyakov]

Would it work with CORS thing btw? It is not related to VS Code extensions?

[vitaliy-guliy]

@akosyakov I don't think there will be any problems with CORS. The URI affects only on background image for tab icon

.webview-icon.webview-widget-1-file-icon::before {
    background-image: url(http://host/any/image.png);
}

It also related to VS Code extensions
https://github.com/eclipse-theia/theia/blob/master/packages/plugin/src/theia.d.ts#L2836

[benoitf]

seems compliant with

theia/packages/plugin-ext/src/main/browser/webviews-main.ts

Line 230 in 657bda8

$setIconPath(handle: string, iconPath: { light: string; dark: string; } | string | undefined): void {

[vitaliy-guliy]

@akosyakov our welcome plugin uses this update
https://github.com/eclipse/che-theia/tree/labeling/plugins/welcome-plugin

You can try to build it and run. It does not use Che plugin API. I suppose it will work perfectly on your side.

PR with updates in Welcome plugin eclipse-che/che-theia#454

Icon field from branding.json is used for tab icon.

[akosyakov]

@vitaliy-guliy thanks, tried, it seems to work

[nickboldt]

When will this be included in a release? When is 0.11.1 or 0.12.0 planned to go live?

[benoitf]

releases of theia are planned each 'last thursday of the month'

[nickboldt]

Oct 24 is too late if we 're still targeting Oct 29 GA. So this becomes something we have to apply as a patch to 0.11.0 in Che-Theia 7.3

[benoitf]

@nickboldt we cut che-theia release whenever we want BTW (no need to have upstream tag)