Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement 'Show Running Tasks...' #5353

Merged
merged 1 commit into from
Jun 5, 2019
Merged

Implement 'Show Running Tasks...' #5353

merged 1 commit into from
Jun 5, 2019

Conversation

vince-fugnitto
Copy link
Member

@vince-fugnitto vince-fugnitto commented Jun 4, 2019 •
edited
Loading

Fixes #5346
Fixed #1100

  • Implement the command and terminal menu item Show Running Tasks...
    which displays the list of currently running tasks, and upon selection,
    sets the focus to the running task's terminal.
  • Fixed issue regarding the creation of the task terminal id.

Signed-off-by: Vincent Fugnitto vincent.fugnitto@ericsson.com

@vince-fugnitto vince-fugnitto added enhancement issues that are enhancements to current functionality - nice to haves tasks issues related to the task system labels Jun 4, 2019
@vince-fugnitto vince-fugnitto requested review from lmcbout and elaihau June 4, 2019 14:02
elaihau
elaihau approved these changes Jun 4, 2019
View reviewed changes
Copy link
Contributor

@elaihau elaihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works well. thank you !

@vince-fugnitto
Implement 'Show Running Tasks...'
003ece4 
Fixes #5346
Fixed #1100

- Implement the command and terminal menu item `Show Running Tasks...`
which displays the list of currently running tasks, and upon selection,
sets the focus to the running task's terminal.
- Implemented a status-bar contribution displaying the number of currently
running tasks, and when clicked, triggers the `Show Running Tasks...` command.
- Fixed issue regarding the creation of the task terminal id.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto force-pushed the vf/GH-5346-running-tasks branch from d6b11e3 to 003ece4 Compare June 4, 2019 15:07
@vince-fugnitto
Copy link
Member Author

@elaihau I updated the PR to your suggestion, as well as fixed #1100 :)

@elaihau
Copy link
Contributor

elaihau commented Jun 4, 2019 •
edited
Loading

With your fix to the terminal id, i am still getting this error.

root ERROR Request getCwdURI failed with error: terminal "7" does not exist Error: terminal "7" does not exist
    at ShellTerminalServer.<anonymous> (/workspace/theia/packages/terminal/lib/node/base-terminal-server.js:117:27)
    at step (/workspace/theia/packages/terminal/lib/node/base-terminal-server.js:59:23)
    at Object.next (/workspace/theia/packages/terminal/lib/node/base-terminal-server.js:40:53)
    at /workspace/theia/packages/terminal/lib/node/base-terminal-server.js:34:71
    at new Promise (<anonymous>)
    at __awaiter (/workspace/theia/packages/terminal/lib/node/base-terminal-server.js:30:12)
    at ShellTerminalServer.BaseTerminalServer.getCwdURI (/workspace/theia/packages/terminal/lib/node/base-terminal-server.js:112:16)
    at JsonRpcProxyFactory.<anonymous> (/workspace/theia/packages/core/lib/common/messaging/proxy-factory.js:217:73)
    at step (/workspace/theia/packages/core/lib/common/messaging/proxy-factory.js:47:23)
    at Object.next (/workspace/theia/packages/core/lib/common/messaging/proxy-factory.js:28:53)
root ERROR Request getCwdURI failed with error: terminal "7" does not exist Error: terminal "7" does not exist
    at ShellTerminalServer.<anonymous> (/workspace/theia/packages/terminal/lib/node/base-terminal-server.js:117:27)
    at step (/workspace/theia/packages/terminal/lib/node/base-terminal-server.js:59:23)
    at Object.next (/workspace/theia/packages/terminal/lib/node/base-terminal-server.js:40:53)
    at /workspace/theia/packages/terminal/lib/node/base-terminal-server.js:34:71
    at new Promise (<anonymous>)
    at __awaiter (/workspace/theia/packages/terminal/lib/node/base-terminal-server.js:30:12)
    at ShellTerminalServer.BaseTerminalServer.getCwdURI (/workspace/theia/packages/terminal/lib/node/base-terminal-server.js:112:16)
    at JsonRpcProxyFactory.<anonymous> (/workspace/theia/packages/core/lib/common/messaging/proxy-factory.js:217:73)
    at step (/workspace/theia/packages/core/lib/common/messaging/proxy-factory.js:47:23)
    at Object.next (/workspace/theia/packages/core/lib/common/messaging/proxy-factory.js:28:53)

This happens when I ctrl + c in the terminal. Is it expected?

@vince-fugnitto
Copy link
Member Author

With your fix to the terminal id, i am still getting this error.

Same as #5328 ?

@elaihau
Copy link
Contributor

elaihau commented Jun 4, 2019

With your fix to the terminal id, i am still getting this error.

Same as #5328 ?

OK it is not introduced by this change. We could handle it in another PR.

@vince-fugnitto
Copy link
Member Author

@lmcbout do you mind trying it out and testing it as well?

@lmcbout
Copy link
Contributor

lmcbout commented Jun 5, 2019

@vince-fugnitto sure, I will do it this morning

lmcbout
lmcbout approved these changes Jun 5, 2019
View reviewed changes
Copy link
Contributor

@lmcbout lmcbout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vince-fugnitto
Copy link
Member Author

Thank you @elaihau @lmcbout !

@vince-fugnitto vince-fugnitto merged commit eb8d5bf into master Jun 5, 2019
@vince-fugnitto vince-fugnitto deleted the vf/GH-5346-running-tasks branch June 5, 2019 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmcbout lmcbout lmcbout approved these changes

@elaihau elaihau elaihau approved these changes

Assignees
No one assigned
Labels
enhancement issues that are enhancements to current functionality - nice to haves tasks issues related to the task system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[tasks] implement 'Show Running Tasks...' command Status bar contribution for tasks
3 participants
@vince-fugnitto @elaihau @lmcbout