Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[plugin/tree] don't pass tree item data over json-rpc #5310

Merged
merged 1 commit into from
Jun 1, 2019
Merged

[plugin/tree] don't pass tree item data over json-rpc #5310

merged 1 commit into from
Jun 1, 2019

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented May 30, 2019 •
edited
Loading

@akosyakov
Copy link
Member Author

@tetchel could you please try whether #4975 is resolved

@akosyakov akosyakov mentioned this pull request May 30, 2019
Closed
@akosyakov akosyakov requested a review from vinokurig May 30, 2019 07:57
@akosyakov
Copy link
Member Author

@vinokurig Could you verify as well when you have a chance?

@akosyakov
Copy link
Member Author

@marcdumais-work if it will be approved please merge before a release, i won't be around today

@akosyakov
[plugin/tree] fix #4975: don't pass tree item data over JSON-RPC
01515b5 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@tetchel
Copy link
Contributor

tetchel commented May 30, 2019

It works great - Thanks so much for the fix, guys!

@marcdumais-work
Copy link
Contributor

Unfortunately this PR was not approved in time to be merged for 0.7.0. How important is it in general? Enough to warrant a 0.7.1 bugfix release?

@akosyakov
Copy link
Member Author

akosyakov commented Jun 1, 2019 •
edited
Loading

@marcdumais-work it is fine, can be released in 0.8.0

@akosyakov akosyakov merged commit 26492e7 into master Jun 1, 2019
@akosyakov akosyakov deleted the GH-4975 branch June 1, 2019 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitf benoitf benoitf approved these changes

@vinokurig vinokurig vinokurig approved these changes

@evidolob evidolob Awaiting requested review from evidolob

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@akosyakov @tetchel @marcdumais-work @benoitf @vinokurig