[plug-in] [vscode] Add some missing entries in env object #4971
Conversation
benoitf
added
plug-in system
| } | ||
|
|
||
| get appRoot() { | ||
| return __dirname; |
There was a problem hiding this comment.
Will this work in web worker?
There was a problem hiding this comment.
will check, I splitted class class for node-mac, I will see how to handle that
good catch
There was a problem hiding this comment.
@mmorhun : ok I've splitted in two classes, one for worker and one for nodejs
in worker env, we don't provide filesystem path as there is no FS BTW
| @@ -20,6 +20,7 @@ | |||
| "@theia/task": "^0.5.0", | |||
| "@theia/workspace": "^0.5.0", | |||
| "decompress": "^4.2.0", | |||
| "getmac": "^1.4.6", | |||
There was a problem hiding this comment.
@marcdumais-work Could you please use your tool to verify this dep?
nvm https://dev.eclipse.org/ipzilla/show_bug.cgi?id=19584 is already resolved
There was a problem hiding this comment.
Florent and I did the analysis anyway for the new dependency and its own recursive dependency tree. All licenses found are Foundation-approved:
It's addressing partially #4446 Change-Id: I589ede711a18322b1afffe0479dace781f450045 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
It's addressing partially #4446 and makes env tests passing at #4224
machineID is using mac address on nodejs while on workers it's a random ID.
Change-Id: I589ede711a18322b1afffe0479dace781f450045
Signed-off-by: Florent Benoit fbenoit@redhat.com