-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHE-3896 add the needed methods for Webview API #4892
Conversation
a004b00
to
69519f4
Compare
@olexii4 please think how we will test it, e.g. provide a sample VS Code extension, play with it in VS Code to learn requirements, describe what to do to verify that APIs work in different scenarios, make the screencast showing it |
fd9f72f
to
575b75e
Compare
The test plugin I am working on the video. |
7f526bb
to
a0c2a07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let me try the same in VS Code |
@olexii4 in the same VS Code it is based on editor groups (tab groups in Theia), not individual editors like in this PR. Here 3 editors in first group and I'm trying to open the webview in 3rd group, so VS Code opens a new group to right. |
@akosyakov Now I see. Previously I tested VS Code with two editor groups (tab groups) and behavior was different: |
@olexii4 It looks like a bug to me. It only happens if the first group has a focus, if you remove a focus (select a navigator) it will open a new group in VS Code as well. Could you file an issue against VS Code to ask whether it is a bug, no need to point to this PR? Maybe we are overlooking something. |
@akosyakov Totally agree with you. It is like a bug for me too. |
@akosyakov WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works good now 👍
Please have a look at comment. I have concerns that it won't work with multiple webviews.
Signed-off-by: Oleksii Orel <oorel@redhat.com>
Add the needed methods for Webview API.
How to test these changes with a test webview-sample:
#3896
Signed-off-by: Oleksii Orel oorel@redhat.com