Ability to proceed runInTerminal request in sidecar container

[tolusha]

Signed-off-by: Anatoliy Bazko abazko@redhat.com

Reference issue

eclipse-che/che#12771

Method overriding is implemented in eclipse-che/che-theia#107

[akosyakov]

that's an API, would be nice to preserve it as options

Also name is very verbose in such way. It is obvious from context that it belongs to DebugSession.

[akosyakov]

Could be here better type than any, i.e. TerminalOptionsExt | undefined?

[akosyakov]

How one will be able to test it?

[tolusha]

@akosyakov

• applied Override terminal creation options eclipse-che/che-theia#107
• built custom images for che-theia, che-theia-endpoint-runtime, che-remote-plugin-python-3.7.2
• created a workspace in a minikube with Python extension
• started a debug session

Debug process was run in a sidecar container

PID   USER     TIME  COMMAND
    1 root      0:02 node /home/theia/lib/node/plugin-remote.js
   48 root      0:00 /usr/local/bin/python completion.py
   51 root      0:00 /usr/local/bin/python lib/python/jedi/evaluate/compiled/subprocess/__main__.py lib/python
  129 root      0:00 node /plugins/ms-python.python.2019.2.5433/extension/out/client/debugger/debugAdapter/main.js
  139 root      0:00 /usr/local/bin/python /plugins/ms-python.python.2019.2.5433/extension/pythonFiles/ptvsd_launche
  163 root      0:00 /bin/ash
  169 root      0:00 ps

[akosyakov]

verified that debugging with integrated terminal still works nicely against Theia and VS Code extensions for Node.js