Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix progress creation #4480

Merged
merged 1 commit into from
Mar 5, 2019
Merged

Fix progress creation #4480

merged 1 commit into from
Mar 5, 2019

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Mar 5, 2019

Signed-off-by: Anatoliy Bazko abazko@redhat.com

Reference issue

There are duplicated progress entries on status bar.
screenshot from 2019-03-04 10-59-59

What does this PR fix

Accordingly to the doc [1] progress is shown while it returned isn't resolved nor rejected. Here is VS Code implementation [2]

[1] https://github.com/Microsoft/vscode/blob/1.31.1/src/vs/vscode.d.ts#L6495-L6497

* Show progress in the editor. Progress is shown while running the given callback
* and while the promise it returned isn't resolved nor rejected. The location at which
* progress should show (and other details) is defined via the passed [`ProgressOptions`](#ProgressOptions).

[2] https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/api/node/extHostProgress.ts#L25

Related issues

#3771

@tolusha tolusha added bug bugs found in the application plug-in system issues related to the plug-in system labels Mar 5, 2019
@tolusha tolusha self-assigned this Mar 5, 2019
@tolusha tolusha requested a review from benoitf as a code owner March 5, 2019 07:51
Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tolusha please remove the two plug-ins binaries before merging

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application plug-in system issues related to the plug-in system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants