Restructuring

[akosyakov]

No description provided.

[svenefftinge]

Nice! For others, it would be good if you could provide an overview of what you did and what the purpose is.

[svenefftinge]

Related to #59

[akosyakov]

It breaks down theia-core on core and filesystem extensions and shows how they are used together for the browser example. It does not relies on ldm anymore but use lerna for linking submodules with hoisting dependencies and 2 tsconfigs, one to improve navigation in vscode, another to compile efficiently. Because of linking debugging works out of the box, without adjusting tsconfigs or generated source maps.

I am going to:

• enable tests again
• add an extension generator
• restructure extensions
• add fs-watcher extension
• restructure examples
• enable examples' tests
• adapt app generators
• add tslint rules for imports, one should always use @theia/${extension}/lib/* imports to import something from other extensions
• update development docs
• remove ldm

[hexa00]

Does that sound like a good time to also change to absolute paths ?
Since you'll have to rewrite the relatives ones anyway

[hexa00]

This is back to .1 ?

[svenefftinge]

I agree, we should keep the version even though we change the package name.

[akosyakov]

ok

[svenefftinge]

You mean use absolute paths even within an npm package?

[hexa00]

I did not realise at first that segmenation would do that by default with the different packages.
Sounds like it would be nide also inside the same package but I'm not sure what is involed there or what is best pratice?

[akosyakov]

I've tried to use the absolute paths inside the same package, e.g. in core @theia/core/lib/*, and rolled back because they are getting long. But what is nice about them that you can copy imports around and move files without breaking imports often.

[svenefftinge]

Otherwise , it worked nicely for me.
Incremental development was easy and fast. :)

[akosyakov]

@svenefftinge I've addressed issues which you mention and update docs.

[hexa00]

I wish you had waited a bit more before merging this ?
I don't understand why this was merged without the examples ci for example ?
Sounds like we're missing some stuff compared to before....
Or I'm missing something

[akosyakov]

Examples are there, only UI tests are switched off for now. I am looking into switching them on.

[hexa00]

Yeah I meant their ci but ok I just think we could have waited to get this in the PR before
I think we should avoid breaking existing stuff in master

[hexa00]

Note also the TLDR doc is now broken
should be cd examples/browser rather than cd ../../examples/browser

[akosyakov]

ok, I will update it

[akosyakov]

@hexa00 I've tried to get it done over the weekend that there are no merge issues. Unfortunately, there was one which I was not able to rebase already because of tree changes and had to merge. There are some small tasks left, I will clean it up next days.

[akosyakov]

I am a bit concern about UI tests, they don't seem to do much but takes so long. Mabe better to have a separate job for them after examples are successfully build.

[akosyakov]

Speed up is because of dependencies are downloaded once for all packages and tasks are executed in parallel there is possible.

[hexa00]

Nice speed up for sure, the colors look nice too hehe :)

[kittaakos]

the colors look nice too

👍

[hexa00]

I think for the UI tests if we start a job after it will be the same as having it in the same job.

If ever our core test become long we could have 2 job in parallel one executing only the core tests and the other the UI tests only. And wait for the 2 to complete.

But I think right now it's the install/compile that is taking time... I'll have to recheck with the restructuring