Add ui tests to travis ci #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: guy perron <guy.perron@ericsson.com>
In order to do so, the ui test npm start script was modified to start the server before running the tests. Because the server start and the tests are running asynchronously, the tests are waiting for a valid connection to be up on the host:port of the test server. Signed-off-by: guy perron <guy.perron@ericsson.com>
|
You should mention also an important change to the ci setup like "Also this changes the travis base distribution to trusty" And your name is missing capital letters on first & last name 1st letter? |
|
We could mention also that this is not compatible with windows... and we should fix it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.