[plug-in] Implement 'plugins' API #2695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evidolob
added
plug-in system
benoitf
reviewed
Aug 29, 2018
| @@ -16,10 +16,10 @@ | |||
|
|
|||
| import { BackendInitializationFn, createAPI, PluginMetadata } from '@theia/plugin-ext'; | |||
|
|
|||
| export const doInitialization: BackendInitializationFn = (rpc: any, pluginMetadata: PluginMetadata) => { | |||
| export const doInitialization: BackendInitializationFn = (rpc: any, manager: any, pluginMetadata: PluginMetadata) => { | |||
There was a problem hiding this comment.
we don't have type for manager ?
benoitf
reviewed
Aug 29, 2018
| // call stop method | ||
| if (pluginData.stopPluginMethod) { | ||
| pluginData.stopPluginMethod(); | ||
| init(raw: PluginMetadata[]): [Plugin[], Plugin[]] { |
There was a problem hiding this comment.
should we use something more meaningful than raw if we know it's of type pluginMetadata ?
benoitf
reviewed
Aug 29, 2018
| @@ -18,9 +18,8 @@ import { CommandRegistryImpl } from './command-registry'; | |||
| import { Emitter } from '@theia/core/lib/common/event'; | |||
| import { CancellationTokenSource } from '@theia/core/lib/common/cancellation'; | |||
| import { QuickOpenExtImpl } from './quick-open'; | |||
| import { MAIN_RPC_CONTEXT, Plugin } from '../api/plugin-api'; | |||
| import { MAIN_RPC_CONTEXT, Plugin as PPlugin, PluginManager } from '../api/plugin-api'; | |||
There was a problem hiding this comment.
could we use another name than PPlugin which might not be clear in the rest of the code
akurinnoy
reviewed
Aug 29, 2018
| model: PluginModel; | ||
| rowModel: PluginPackage; |
akurinnoy
reviewed
Aug 29, 2018
| @@ -360,7 +361,7 @@ export interface PluginLifecycle { | |||
| * The export function of initialization module of backend plugin. | |||
| */ | |||
| export interface BackendInitializationFn { | |||
| (rpc: RPCProtocol, pluginMetadata: PluginMetadata): void; | |||
| (rpc: RPCProtocol, manger: PluginManager, pluginMetadata: PluginMetadata): void; | |||
akurinnoy
reviewed
Aug 29, 2018
| init(data: PluginMetadata[]): [Plugin[], Plugin[]]; | ||
| } | ||
|
|
||
| interface StopFun { |
There was a problem hiding this comment.
If you don't mind let it be StopFn or StopFunc.
There was a problem hiding this comment.
I was thinking the same :-) let's still have some FUN :-)
evidolob
added a commit
that referenced
this pull request
Aug 29, 2018
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
evidolob
added a commit
that referenced
this pull request
Aug 29, 2018
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
akurinnoy
approved these changes
Aug 29, 2018
|
are you gonna remove the merge commit (use rebase instead ? ) |
|
Yes, I wait approve before squashing commits |
benoitf
approved these changes
Aug 29, 2018
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add namespace for dealing with installed plug-ins. Plug-ins are represented
by an Plugin-interface which enables reflection on them.
Plug-in writers can provide APIs to other plug-ins by returning their API public
API from the
start-call.Issue: #2561
Signed-off-by: Yevhen Vydolob yvydolob@redhat.com