Workspace folders API #2141
Merged
Workspace folders API #2141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaliy-guliy
requested review from
svenefftinge,
benoitf,
evidolob,
ashumilova,
akosyakov,
spoenemann,
olexii4,
AndrienkoAleksandr and
mmorhun
4 tasks
evidolob
reviewed
Jun 20, 2018
packages/plugin/src/theia.d.ts
Outdated
| * | ||
| * @readonly | ||
| */ | ||
| export let rootPath: string | undefined; |
There was a problem hiding this comment.
This is deprecated field in vscode workspace api, can you remove it?
18 tasks
mmorhun
approved these changes
Jun 21, 2018
|
|
||
| private folders: WorkspaceFolder[] | undefined; | ||
|
|
||
| constructor(rpc: RPCProtocol) { |
There was a problem hiding this comment.
Removed. Thanks
vitaliy-guliy
force-pushed
the
workspace-folders-api
branch
from
36389a6
to
27c0cd9
Compare
AndrienkoAleksandr
approved these changes
Jun 21, 2018
evidolob
approved these changes
Jun 21, 2018
benoitf
reviewed
Jun 21, 2018
|
|
||
| // tslint:disable-next-line:no-unused-variable | ||
| // @ts-ignore | ||
| const workspaceMain = new WorkspaceMain(rpc, workspaceService); |
There was a problem hiding this comment.
do we need to declare the variable ? if not used
There was a problem hiding this comment.
Removed. Thanks.
Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
vitaliy-guliy
force-pushed
the
workspace-folders-api
branch
from
5fe3b12
to
1855322
Compare
benoitf
approved these changes
Jun 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugin API to get information about workspace folder.
Signed-off-by: Vitaliy Gulyy vgulyy@redhat.com