fix workspace preference provider #2083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosyakov
reviewed
Jun 9, 2018
| @@ -25,6 +25,13 @@ export abstract class AbstractResourcePreferenceProvider extends PreferenceProvi | |||
| @postConstruct() | |||
| protected async init(): Promise<void> { | |||
| const uri = await this.getUri(); | |||
There was a problem hiding this comment.
please update a return type of getUri accordingly, i.e. MaybePromise<URI | undefined>
| @@ -22,7 +22,7 @@ export class WorkspacePreferenceProvider extends AbstractResourcePreferenceProvi | |||
| const rootUri = new URI(root.uri); | |||
| return rootUri.resolve('.theia').resolve('settings.json'); | |||
| } | |||
| return new Promise<URI>(() => { }); | |||
| return new Promise<URI>(resolve => resolve()); | |||
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
akurinnoy
force-pushed
the
fix-preference-provider
branch
from
5739f7c
to
2d4128a
Compare
|
@akosyakov review, please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Theia starts without opened workspace then method
getUri()of WorkspacePreferenceProvider returns a promise which never becomes resolved. Hence, WorkspacePreferenceProvider can't be initialized as well.Signed-off-by: Oleksii Kurinnyi okurinny@redhat.com