Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix monaco editor localization #15016

Merged
merged 2 commits into from
Feb 25, 2025
Merged

Fix monaco editor localization #15016

merged 2 commits into from
Feb 25, 2025

Conversation

msujew
Copy link
Member

@msujew msujew commented Feb 24, 2025

What it does

Closes #14995

After overriding the localize and localize2 function of monaco, some pieces still weren't translated correctly, since their keys didn't match up as expected anymore in the nls.metadata.json file which wasn't updated in a while. This PR also updates that file to ensure that everything is translated correctly.

Also deletes the old monaco-nls.json file which was no longer required (but I forgot to delete it).

How to test

  1. Run the Configure Display Language command and select a non-English language
  2. Ensure that all monaco menus/commands are correctly translated.

Review checklist

Reminder for reviewers

@msujew msujew added monaco issues related to monaco localization issues related to localization/internalization/nls labels Feb 24, 2025
@tsmaeder
Copy link
Contributor

I've opened #15035 to track things that are not I18Ned even with this PR. Some of them seem to be simply oversights. I suggest we merge this one and address the remaining issue later.

@msujew msujew merged commit d5b3afc into master Feb 25, 2025
10 of 11 checks passed
@msujew msujew deleted the msujew/fix-monaco-nls branch February 25, 2025 10:28
@github-actions github-actions bot added this to the 1.59.0 milestone Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization issues related to localization/internalization/nls monaco issues related to monaco
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Missing i18n for Submenu Labels under "Select" Menu
2 participants