Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change trigger inline suggestion keybinding to Ctrl+Alt+Space #14669

Merged
merged 2 commits into from
Dec 25, 2024

Conversation

JonasHelming
Copy link
Contributor

fixed #14665

What it does

Due to #14665 we change the default key binding to trigger the line suggestion to Ctrl+Alt+Space. This is unused in Theia by default. In VS Code it toggles the focus in case a suggestion widget is open, so even if this would be added to theia, it is a different context.

How to test

Press Ctrl+Alt+Space and see the inline suggestion triggered.

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Review checklist

Reminder for reviewers

Copy link
Contributor

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me! 👍

@JonasHelming JonasHelming merged commit 02f4192 into master Dec 25, 2024
9 of 11 checks passed
@github-actions github-actions bot added this to the 1.58.0 milestone Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Shift + Space should output a space (blank) character in the editor unless other key bindings are used
2 participants