Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rimraf to 5 #14273

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Update rimraf to 5 #14273

merged 3 commits into from
Oct 9, 2024

Conversation

JonasHelming
Copy link
Contributor

fixed #14272

Update rimraf to 5, prior versions are deprecated, 6 does not support Node 18

Review checklist

Reminder for reviewers

@JonasHelming JonasHelming marked this pull request as draft October 8, 2024 15:13
fixed #14272

Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I found some issues with the code adaptions, please have a look.

packages/git/src/browser/git-scm-provider.spec.ts Outdated Show resolved Hide resolved
JonasHelming and others added 2 commits October 9, 2024 14:36
Co-authored-by: Stefan Dirix <sdirix@eclipsesource.com>
Co-authored-by: Stefan Dirix <sdirix@eclipsesource.com>
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks 👍

@JonasHelming JonasHelming merged commit f1dc1d3 into master Oct 9, 2024
11 checks passed
@github-actions github-actions bot added this to the 1.55.0 milestone Oct 9, 2024
@sdirix sdirix deleted the GH-14272 branch October 9, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Upgrade rimraf
2 participants