Fixed notebook editor staying current even when selecting sidebar or bottom panel #14262
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This lets the current notebook editor stay as active in the plugin host even when selecting another widget as long as the notebook-editor is visible and no other text-editor is selected
How to test
you can find an vscoed extension here which adds an output channel to show the cahnge events. See that the active notebook editor and cell editor should stay even when selecting another non text-editor widget.
Follow-ups
This still has the same issues as the text editor active handling. For example having a text or notebook editor open and a custom editor right beside it so both are visible, then focusing the custom editor does not change the vscode api
activeTextEditor
orActiveNotebookEditor
Review checklist
Reminder for reviewers