Orchestrator logs its own requests #14255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add data field to request - add option to turn off default logging - extracted getJsonOfText - add docu for getTextOfResponse fixed #14252 Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
planger
approved these changes
Oct 6, 2024
Co-authored-by: Philip Langer <planger@eclipsesource.com>
Co-authored-by: Philip Langer <planger@eclipsesource.com>
Co-authored-by: Philip Langer <planger@eclipsesource.com>
Co-authored-by: Philip Langer <planger@eclipsesource.com>
Co-authored-by: Philip Langer <planger@eclipsesource.com>
Co-authored-by: Philip Langer <planger@eclipsesource.com>
Co-authored-by: Philip Langer <planger@eclipsesource.com>
Co-authored-by: Philip Langer <planger@eclipsesource.com>
JonasHelming
commented
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #14252
What it does
Orchestrator logs its own requests separatly from the agent it delegates to.
It also adds a data field to 'request' to remember the orchestrator request id which is manually generated.
It refactors getJsonOfResponse and adds getJsonOfText
It adds documentation to getTextOfResponse to avoid other people falling into this trap: " Important: For stream responses, the stream can only be consumed once. Calling this function multiple times on the same stream response will return an empty string (
'') on subsequent calls, as the stream will have already been consumed."How to test
Do any chat requests and check the history view. For the orchestrator it should log the user requests and then the choosen agent. For the choosen agent, it should log the user request and they actual answer.
Review checklist
Reminder for reviewers