Add enable state of agent to preferences #14206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is currently based on #14177 and will be rebased as soon as the other one is merged |
The selected model was already persisted in the preferences, but the enablement state was not. Here the settings were extended to include the enablement state. The new setting is consumed and updated from the AgentService. Fixes eclipse-theia#14205
eneufeld
force-pushed
the
fix/ai-agent-persistence
branch
from
31d729e
to
c029ec3
Compare
sdirix
approved these changes
Sep 20, 2024
|
|
||
| @injectable() | ||
| export class AISettingsService { | ||
| export class AISettingsServiceImpl implements AISettingsService { | ||
| @inject(PreferenceService) protected preferenceService: PreferenceService; | ||
| static readonly PREFERENCE_NAME = 'ai.settings'; |
There was a problem hiding this comment.
Not directly related to this PR but we should align this with the other preferences we store, i.e. this should be
Suggested change
| static readonly PREFERENCE_NAME = 'ai.settings'; | |
| static readonly PREFERENCE_NAME = 'ai-features.agentSettings'; |
Edit: done with 574940b
JonasHelming
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The selected model was already persisted in the preferences,
but the enablement state was not.
Here the settings were extended to include the enablement state.
The new setting is consumed and updated from the AgentService.
Fixes #14205
How to test
Enable/Disable an agent and reload the page and check the agent has the same state of enablement as before the reload.
Follow-ups
Review checklist
Reminder for reviewers