Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disabling an agent also disables its UIContribution #14184

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

eneufeld
Copy link
Contributor

What it does

  • agent service had a loop so that a single instance was not created
  • code completion agents now check whether they are active
  • terminal agent now check whether it is active
  • chat-service correctly handles no available agents now

fixes #14167

How to test

Go through the Ai Configuration View and deactivate different agents and check whether they are used by the Orchestrator Agent and what happens if you deactivate all of them.

Follow-ups

Review checklist

Reminder for reviewers

- agent service had a loop so that a single instance was not created
- code completion agents now check whether they are active
- terminal agent now check whether it is active
- chat-service correctly handles no available agents now

fixes eclipse-theia#14167
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

It also fixes some other issues which occur because of the inversify loop, e.g. not being able to edit prompts.

@JonasHelming JonasHelming merged commit bdbe90e into eclipse-theia:master Sep 18, 2024
11 checks passed
@sgraband sgraband added this to the 1.54.0 milestone Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Disabled agents: also disable UI Contributions (113)
4 participants