Move TerminalShellIntegration stubs to main theia API #14168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes eclipse-theia#14107 contributed on behalf of STMicroelectronics Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
rschnekenbu
force-pushed
the
issues/14107
branch
from
378f6bf
to
dfcf766
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Moves already stubbed API from proposed to main API for TerminalShellIntegration
As developed in the issue #14107, implementation of the feature is a large task that needs to be planned and evaluated. Moving already stubbed API is a safe move for this month.
Fixes #14107
Contributed on behalf of STMicroelectronics
How to test
Install latest Python as described in PR #14058 (2024.12.3). Ensure that the extension works doesn't crash on startup.
Follow-ups
Implement stubbed API. see task #14169
Review checklist
Reminder for reviewers