Add handling of multiple accounts to authentication api #14149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes eclipse-theia#14110 Contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
|
Here's the extensions |
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
rschnekenbu
approved these changes
Sep 12, 2024
| @@ -104,14 +101,14 @@ export interface AuthenticationProvider { | |||
| * these permissions, otherwise all sessions should be returned. | |||
| * @returns A promise that resolves to an array of authentication sessions. | |||
There was a problem hiding this comment.
With the addition of the parameter, the documentation may also be updated.
| @@ -104,14 +101,14 @@ export interface AuthenticationProvider { | |||
| * these permissions, otherwise all sessions should be returned. | |||
| * @returns A promise that resolves to an array of authentication sessions. | |||
| */ | |||
| getSessions(scopes?: string[]): Thenable<ReadonlyArray<AuthenticationSession>>; | |||
| getSessions(scopes: string[] | undefined, account?: AuthenticationSessionAccountInformation): Thenable<ReadonlyArray<AuthenticationSession>>; | |||
|
|
|||
| /** | |||
| * Prompts a user to login. | |||
| * @param scopes A list of scopes, permissions, that the new session should be created with. | |||
| * @returns A promise that resolves to an authentication session. | |||
| $getSessions(id: string, scopes?: string[]): Promise<ReadonlyArray<theia.AuthenticationSession>>; | ||
| $createSession(id: string, scopes: string[]): Promise<theia.AuthenticationSession>; | ||
| $getSessions(providerId: string, scopes: string[] | undefined, options: theia.AuthenticationProviderSessionOptions): Promise<ReadonlyArray<theia.AuthenticationSession>>; | ||
| $createSession(id: string, scopes: string[], options: theia.AuthenticationProviderSessionOptions): Promise<theia.AuthenticationSession>; |
There was a problem hiding this comment.
Would it make also sense for coherence to rename parameter in create/remove session? Implementation wise, they are already naming it providerId
There was a problem hiding this comment.
If we do this, it would make sense to update the parameter name everywhere, but that's not really in the scope of this PR, IMO.
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Adds "account" parameter to
get/createSession()calls. This allows to handle multiple accounts with the same scopes for the same authentication provider. This may be a breaking change for users and implementers ofAuthenticationService. Also removed two deprecated methods.Fixes #14110
Contributed on behalf of STMicroelectronics
How to test
The attached extensions contributes four commands:
Allows to log in with the Auth Test provider. Either into a preexisting session or with a new user name. The "default session" setting gets cleared.
Asks the system for a auth session while clearing the preferred session preference
Same as above, but don't clear the preferred session preference
Same as above, but you can select a specific user name the system will ask for
Follow-ups
Review checklist
Reminder for reviewers