Fix selection of contributed menu action argument adapters #14132
+31
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes eclipse-theia#14072 Contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>om>
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
rschnekenbu
approved these changes
Sep 5, 2024
jfaltermeier
pushed a commit
that referenced
this pull request
Sep 6, 2024
Fixes #14072 Contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>om>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The idea is that a toolbar item has two different 'menuPath' fields: one to pick the argument adapter for the toolbar item, the second is to display a drop-down menu for the toolbar item. Also, an argument adapter is selected for an item when the registered path for the adapter is a prefix of the toolbar item menu path field. This takes care of contributed items in toolbar drop downs like the gitlens editor toolbar menu.
Fixes #14072
Contributed on behalf of STMicroelectronics
How to test
Test the various toolbar and context menus one can contribute to. Make sure the actions work and drop-downs are shown where appropriate. You can get an indication of the interesting locations in plugin-menu-command-adapter.
Follow-ups
Review checklist
Reminder for reviewers